test: Strengthen some of the doc store mixin tests - #12047
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
davidsbatista
added
the
ignore-for-release-notes
sjrl
enabled auto-merge (squash)
July 17, 2026 09:38
sjrl
changed the title
Contributor
|
Curious to see if any doc_store tests now fail, but can only check it after a new release, since the integrations Mixin tests rely on the pip package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Strengthen the document store testing mixins so that naive wrong implementations can no longer pass. The existing tests asserted correct expected values, but several used data where a store could skip work and still produce the right numbers. No mixin semantics change — only test data and assertion strictness. Sync and async variants are updated identically.
How did you test it?
Updated tests
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.